feat(dashboard): Nv 4800 implement arrays and nested forms in custom step controls #7127
+412
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BiswaViraj
changed the title
BiswaViraj
commented
Nov 26, 2024
There was a problem hiding this comment.
for the Array went with the UI similar to the objects instead of using the tag-input as it will make it complex to handle different scenarios and also doesn't play well with the rjsf form
…ieldTemplate for improved workflow editor UI
…rt and improved input handling
…nce and add buildDefaultValuesOfDataSchema utility
… getFieldName utility in widget components
…StepTabs component
…ate for improved form handling and structure
…fault values and improved dirty state management
…plete integration
BiswaViraj
force-pushed
the
nv-4800-implement-arrays-and-nested-forms-in-custom-step-controls
branch
from
713c76f
to
d7557d7
Compare
rifont
reviewed
Nov 27, 2024
| registry={registry} | ||
| /> | ||
| </span> | ||
| <div className="bg-background text-foreground-600 -mt-px ml-auto mr-4 flex items-center gap-1"> |
There was a problem hiding this comment.
Could we add a hover state to the collapsible button to be consistent with the add/minus button hover states?
It's generally a good UX practice for all buttons to have a hover state to provide feedback to the user that they are interacting with something (in addition to varying the pointer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Screen.Recording.2024-11-25.at.11.56.13.PM.mov
Expand for optional sections
Related enterprise PR
Special notes for your reviewer